Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added authz as new validation. #14

Merged
merged 3 commits into from
May 9, 2023
Merged

Added authz as new validation. #14

merged 3 commits into from
May 9, 2023

Conversation

halleysouza
Copy link
Collaborator

New branch with IAM authz validations and moved gce_service() to new api.py

@halleysouza
Copy link
Collaborator Author

@runxinw could pls review and merge this PR ? thanks

@halleysouza halleysouza requested a review from runxinw May 8, 2023 16:20
@runxinw
Copy link
Collaborator

runxinw commented May 9, 2023

comments have been addressed , close the PR

@runxinw runxinw closed this May 9, 2023
@halleysouza halleysouza reopened this May 9, 2023
Copy link
Collaborator

@runxinw runxinw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
comments have been provided previously and addressed;

@runxinw runxinw merged commit 9d1e1db into develop May 9, 2023
@halleysouza halleysouza deleted the authz_validation branch May 9, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants